Re: Commit "mac80211: fix race in ieee80211_register_hw()" breaks mac80211 debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,

On Thu, 23 Apr 2020 at 13:29, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Hauke, Sumit,
>
> > > Felix reported that the file /sys/kernel/debug/ieee80211/phy0/rc is now
> > > located at /sys/kernel/debug/rc.
>
> Yeah, we noticed this the other day too.
>
> > +++ b/net/wireless/core.c
> > @@ -473,6 +473,10 @@ struct wiphy *wiphy_new_nm(const struct
> > cfg80211_ops *ops, int sizeof_priv,
> >                 }
> >         }
> >
> > +       /* add to debugfs */
> > +       rdev->wiphy.debugfsdir = debugfs_create_dir(wiphy_name(&rdev->wiphy),
> > +                                                   ieee80211_debugfs_dir);
>
> This cannot work, we haven't committed to the name of the wiphy yet at
> this point.

Maybe I am missing something, can you please elaborate here?

Looking at the code, the default or requested wiphy name is configured
just above this and the rename API "cfg80211_dev_rename()" takes care
of renaming wiphy debugfs directory too.

-Sumit

>
> I have some fixes, I'll send them out asap.
>
> johannes
>



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux