RE: [patch NOT added to the 3.12 stable tree] mtd: nand: omap: fix ecclayout to be in sync with u-boot NAND driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jiri,

>From: Jiri Slaby [mailto:jslaby@xxxxxxx]
>
>From: Pekon Gupta <pekon@xxxxxx>
>
>This patch does NOT apply to the 3.12 stable tree. If you still want
>it applied, please provide a backport.
>
>===============
>
>commit eae39cb4934d3daab3ec828c5201c955b2e56af9 upstream.
>
>Fixes: commit a919e51161b58ed7e6e663daba99ab7d558808f3
>       mtd: nand: omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe
>
>Fixes ecclayout mismatch introduced in above commit for following ecc-schemes:
> - OMAP_ECC_BCH4_CODE_HW_DETECTION_SW
> - OMAP_ECC_BCH8_CODE_HW_DETECTION_SW
> However, this patch also touches other ecc-schemes as the fix required
> refactoring common code, into ecc-scheme specific code.
>
>This patch aligns ecc-layout for below ecc-schemes as per reference [1],[2],[3]
>
> +---+------------+-------------++-------------+-------------+
> |OOB|BCH8_CODE_HW|BCH8_CODE_HW_||HAM1_CODE_HW |HAM1_CODE_HW |
> |pos|            | DETECTION_SW||(x8 device)  |(x16 device) |
> +---+------------+-------------++-------------+-------------+
> | 0 |BADBLK_MARK | BADBLK_MARK || BADBLK_MARK | BADBLK_MARK |
> | 1 |BADBLK_MARK | BADBLK_MARK || eccpos[0]   | BADBLK_MARK |
> | 2 | eccpos[0]  | eccpos[0]   || eccpos[1]   | eccpos[0]   |
> | 3 | eccpos[1]  | eccpos[1]   || eccpos[2]   | eccpos[1]   |
> | 4 | eccpos[2]  | eccpos[2]   || eccpos[3]   | eccpos[2]   |
> | 5 | eccpos[3]  | eccpos[3]   || eccpos[4]   | eccpos[3]   |
> | 6 | eccpos[4]  | eccpos[4]   || eccpos[5]   | eccpos[4]   |
> | 7 | eccpos[5]  | eccpos[5]   || eccpos[6]   | eccpos[5]   |
> | 8 | eccpos[6]  | eccpos[6]   || eccpos[7]   | eccpos[6]   |
> | 9 | eccpos[7]  | eccpos[7]   || eccpos[8]   | eccpos[7]   |
> |10 | eccpos[8]  | eccpos[8]   || eccpos[9]   | eccpos[8]   |
> |11 | eccpos[9]  | eccpos[9]   || eccpos[10]  | eccpos[9]   |
> |12 | eccpos[10] | eccpos[10]  || eccpos[11]  | eccpos[10]  |
> |13 | eccpos[11] | eccpos[11]  || oobfree[0]  | eccpos[11]  |
> |14 | eccpos[12] | eccpos[12]  || oobfree[1]  | oobfree[0]  |
> |15 | eccpos[13] | <reserved>  || oobfree[2]  | oobfree[1]  |
> +---+------------+-------------++-------------+-------------+
> |16 | eccpos[14] | eccpos[13]  || oobfree[3]  | oobfree[2]  |
> |...| [...]      | [...]       || [...]       | [...]       |
> |56 | eccpos[54] | eccpos[51]  || oobfree[43] | oobfree[42] |
> |57 | eccpos[55] | <reserved>  || oobfree[44] | oobfree[43] |
> +===+============+=============+==============+=============+
> |58 | oobfree[0] | oobfree[0]  || oobfree[45] | oobfree[44] |
> |59 | oobfree[1] | oobfree[1]  || oobfree[46] | oobfree[45] |
> |60 | oobfree[2] | oobfree[2]  || oobfree[47] | oobfree[46] |
> |61 | oobfree[3] | oobfree[3]  || oobfree[48] | oobfree[47] |
> |62 | oobfree[4] | oobfree[4]  || oobfree[49] | oobfree[48] |
> |63 | oobfree[5] | oobfree[5]  || oobfree[50] | oobfree[49] |
> +---+------------+-------------+--------------+-------------+
>
>[1] ecc-layout expected by ROM code, as specified in SoC TRM under:
>      Chapter="Initialization"
>        Section="Device Initialization by ROM code"
>            Sub-Section="Memory Booting"
>                Heading="NAND"
>                Figure="ECC Locations in NAND Spare Areas"
>
>[2] ecc-layout updates in u-boot
>    http://lists.denx.de/pipermail/u-boot/2013-November/167551.html
>
>[3] u-boot configurations to match above ecc-layout are documented at
>    https://processors.wiki.ti.com/index.php/Linux_Core_NAND_User%27s_Guide
>
>CC: <stable@xxxxxxxxxxxxxxx> # 3.13.x+
>
The mentioned patches fix the regression introduced in 3.13.x+
These are not intended for 3.12 or previous kernel versions.
So, please ignore them.

Same applies to other below patches..
	[PATCH] mtd: nand: omap: fix ecclayout->oobfree->length
	[PATCH] mtd: nand: omap: fix ecclayout->oobfree->offset


with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]