On Tue, Apr 14, 2020 at 07:15:08PM +0200, Hans de Goede wrote: > Sounds good, I guess it would be best to combine that with a: > > if (priv->irq == 0) > return; > > At the top of disable_interrupts() and then unconditionally > call disable_interrupts() where your v1 of this patch > calls devm_free_irq(). That would be a reasonable clean > solution I think. Great, this was my plan (just wanted to double check). /Jarkko