On Wed, Apr 15, 2020 at 10:51:37AM -0700, Nick Desaulniers wrote:
On Tue, Apr 14, 2020 at 5:56 PM 'Guenter Roeck' via Clang Built Linux
<clang-built-linux@xxxxxxxxxxxxxxxx> wrote:
On Tue, Apr 14, 2020 at 5:26 PM Nathan Chancellor
<natechancellor@xxxxxxxxx> wrote:
>
> Hi all,
>
> Sorry for yet another convergeance on this commit... :/ hopefully this
> does not continue for much longer. None of the warnings are obviously
> caused by the patch below.
Fixed by commit 85dc2c65e6c9 ("misc: echo: Remove unnecessary
parentheses and simplify check for zero").
>
No worries.
I noticed that the problems are pretty much all fixed in the upstream
kernel. I just wasn't sure if it would be worthwhile sending a request
to stable@ to have them applied to 4.19.y (and if necessary 5.4.y).
Any suggestions ?
We should strive to be warning free on stable. Thanks for identifying
the fix Nathan.
Greg, Sasha,
Would you please cherry pick 85dc2c65e6c9 to 4.19.y, 4.14.y, 4.9.y,
and 4.4.y (maybe 3.18, didn't check that one)? It applies cleanly and
is a trivial fix for a warning that landed in v4.20-rc1.
I'll grab it, but could we please look into disabling some clang
warnings?
I understand warnings that might warn us about dangerous code, but this
reads to me like something checkpatch might complain about...
--
Thanks,
Sasha
