Re: [PATCH 4.19 10/13] wil6210: remove reset file from debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 11 Apr 2020, Greg KH wrote:

> On Fri, Apr 03, 2020 at 01:18:56PM +0100, Lee Jones wrote:
> > From: Karthick Gopalasubramanian <kargop@xxxxxxxxxxxxxx>
> > 
> > [ Upstream commit 32dcfe8316cdbd885542967c0c85f5b9de78874b ]
> > 
> > Reset file is not used and may cause race conditions
> > with operational driver if used.
> > 
> > Signed-off-by: Karthick Gopalasubramanian <kargop@xxxxxxxxxxxxxx>
> > Signed-off-by: Maya Erez <merez@xxxxxxxxxxxxxx>
> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> >  drivers/net/wireless/ath/wil6210/debugfs.c | 27 ----------------------
> >  1 file changed, 27 deletions(-)
> 
> Why is this a patch for stable kernels?  debugfs is only for root, and
> can do much worst things than this, which is why it shouldn't be
> mounted/enabled on "real" systems.

This wasn't backported due to security issues.

It was backported since:

  "[The] Reset file ... may cause race conditions"

Final call is yours, as always.  Please do as you see fit.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux