Hi, > -----Original Message----- > From: Greg KH [mailto:greg@xxxxxxxxx] > Sent: Friday, April 10, 2020 5:42 PM > To: iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Subject: Re: [PATCH for 4.4.y] x86/vdso: Fix lsl operand order > > On Wed, Apr 08, 2020 at 05:24:30PM +0900, Nobuhiro Iwamatsu wrote: > > From: Samuel Neves <sneves@xxxxxxxxx> > > > > commit e78e5a91456fcecaa2efbb3706572fe043766f4d upstream. > > > > In the __getcpu function, lsl is using the wrong target and destination > > registers. Luckily, the compiler tends to choose %eax for both variables, > > so it has been working so far. > > > > Fixes: a582c540ac1b ("x86/vdso: Use RDPID in preference to LSL when available") > > Signed-off-by: Samuel Neves <sneves@xxxxxxxxx> > > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > Acked-by: Andy Lutomirski <luto@xxxxxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx > > Link: https://lkml.kernel.org/r/20180901201452.27828-1-sneves@xxxxxxxxx > > Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > --- > > arch/x86/include/asm/vgtod.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > What about 4.9? I can't take a patch for 4.4 without also it being in > newer kernels. > > ANd always cc: all the people involved in a patch, let them have a say > if this is ok or not. > > Please fix up and resend for both trees. OK, I will fix this patch and resend. Thanks for your comment. Nobuhiro
