On Thu, Apr 02, 2020 at 08:12:20PM +0100, Lee Jones wrote: > From: George Spelvin <lkml@xxxxxxx> > > [ Upstream commit 043b3f7b6388fca6be86ca82979f66c5723a0d10 ] > > Rather than a fixed-size array of pending sorted runs, use the ->prev > links to keep track of things. This reduces stack usage, eliminates > some ugly overflow handling, and reduces the code size. > > Also: > * merge() no longer needs to handle NULL inputs, so simplify. > * The same applies to merge_and_restore_back_links(), which is renamed > to the less ponderous merge_final(). (It's a static helper function, > so we don't need a super-descriptive name; comments will do.) > * Document the actual return value requirements on the (*cmp)() > function; some callers are already using this feature. > > x86-64 code size 1086 -> 739 bytes (-347) > > (Yes, I see checkpatch complaining about no space after comma in > "__attribute__((nonnull(2,3,4,5)))". Checkpatch is wrong.) > > Feedback from Rasmus Villemoes, Andy Shevchenko and Geert Uytterhoeven. Random patch chosen from the list, why is this needed? What issue does this fix? Where did it come from? Also, you need to cc: all of the people involved in a patch for when you submit them to the stable trees, to give them a chance to weigh in and say "no, that should not go there." Please do that for all of these series, and provide a 00/XX email. I'm dropping them all from my queue for now, thanks. greg k-h
