Re: [patch added to the 3.12 stable tree] Btrfs: return immediately if tree log mod is not necessary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 01, 2014 at 01:10:32PM +0100, Jiri Slaby wrote:
> From: Filipe David Borba Manana <fdmanana@xxxxxxxxx>
> 
> This patch has been added to the 3.12 stable tree. If you have any
> objections, please let us know.
> 
> ===============
> 
> In ctree.c:tree_mod_log_set_node_key() we were calling
> __tree_mod_log_insert_key() even when the modification doesn't need
> to be logged. This would allocate a tree_mod_elem structure, fill it
> and pass it to  __tree_mod_log_insert(), which would just acquire
> the tree mod log write lock and then free the tree_mod_elem structure
> and return (that is, a no-op).
> 
> Therefore call tree_mod_log_insert() instead of __tree_mod_log_insert()
> which just returns immediately if the modification doesn't need to be
> logged (without allocating the structure, fill it, acquire write lock,
> free structure).
> 
> Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx>
> Signed-off-by: Josef Bacik <jbacik@xxxxxx>
> Signed-off-by: Chris Mason <clm@xxxxxx>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> ---

I don't see the upstream commit id in these patches, which is required
to have in a stable patch.  Can you add them to the commit in the format
that I used, or in some standard format so that tools can check them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]