On Sun, Mar 29, 2020 at 2:41 PM Jason Andryuk <jandryuk@xxxxxxxxx> wrote: > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > commit 7937fd3227055892e169f4b34d21157e57d919e2 upstream. > > The code now compiles without ACPI, but there's a warning since > iwl_mvm_get_ppag_table() isn't used, and iwl_mvm_ppag_init() must > not unconditionally fail but return success instead. > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> > Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> > [Drop hunk removing iwl_mvm_get_ppag_table() since it doesn't exist in > 5.4] > Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx> > --- > A 5.4 kernel can't "up" an iwlwifi interface when CONFIG_ACPI=n. > `wpa_supplicant` or `ip link set wlan0 up` return "No such file or > directory". The non-acpi stub iwl_mvm_ppag_init() always returns > -ENOENT which means iwl_mvm_up() always fails. Backporting the commit > lets iwl_mvm_up() succeed. This stable request is only applicable to 5.4 Fixes 6ce1e5c0c207 "iwlwifi: support per-platform antenna gain" -Jason
