Re: [PATCH] ARM: dts: exynos: Fix GPIO polarity for thr GalaxyS3 CM36651 sensor's bus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 26, 2020 at 03:20:37PM +0100, Marek Szyprowski wrote:
> GPIO lines for the CM36651 sensor I2C bus use the normal not the inverted
> polarity. This bug has been there since adding the CM36651 sensor by
> commit 85cb4e0bd2294, but went unnoticed because the "i2c-gpio" driver
> ignored the GPIO polarity specified in the device-tree.
> 
> The recent conversion of "i2c-gpio" driver to the new, descriptor based
> GPIO API, automatically made it the DT-specified polarity aware, what
> broke the CM36651 sensor operation.
> 
> Fixes: c769eaf7a85d ("ARM: dts: exynos: Split Trats2 DTS in preparation for Midas boards")
> Fixes: c10d3290cbde ("ARM: dts: Use GPIO constants for flags cells in exynos4412 boards")
> Fixes: 85cb4e0bd229 ("ARM: dts: add cm36651 light/proximity sensor node for exynos4412-trats2")

Thanks, applied. I kept only last Fixes as this is the original error.
All later were just refactorings of the same bug.

Best regards,
Krzysztof




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux