On Mon, Mar 16, 2020 at 02:19:38PM +0100, Vladis Dronov wrote: > commit d6c066fda90d578aacdf19771a027ed484a79825 upstream. > > Add a sanity check to efivar_store_raw() the same way > efivar_{attr,size,data}_read() and efivar_show_raw() have it. > > Signed-off-by: Vladis Dronov <vdronov@xxxxxxxxxx> > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx> > Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> > Link: https://lore.kernel.org/r/20200305084041.24053-3-vdronov@xxxxxxxxxx > Link: https://lore.kernel.org/r/20200308080859.21568-25-ardb@xxxxxxxxxx > --- > drivers/firmware/efi/efivars.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c > index c8688490f148..1c65f5ac4368 100644 > --- a/drivers/firmware/efi/efivars.c > +++ b/drivers/firmware/efi/efivars.c > @@ -272,6 +272,9 @@ efivar_store_raw(struct efivar_entry *entry, const char *buf, size_t count) > u8 *data; > int err; > > + if (!entry || !buf) > + return -EINVAL; > + > if (is_compat()) { > struct compat_efi_variable *compat; > > -- > 2.20.1 > Now queued up, thanks. greg k-h