On Tue, Mar 10, 2020 at 03:59:25PM -0500, Tom Lendacky wrote: > On 3/10/20 1:42 PM, Tom Lendacky wrote: > > On 3/10/20 1:19 PM, Sean Christopherson wrote: > >> Has this been tested on the stable kernels? There's a recent bug report[*] > >> that suggests the 4.19 backport of this patch may be causing issues. > > > > I missed this went the stable patches went by... when backported to the > > older version of kvm_mmu_set_mmio_spte_mask() in the stable kernels (4.14 > > and 4.19), the call should have been: > > > > kvm_mmu_set_mmio_spte_mask(mask, mask) and not: > > > > kvm_mmu_set_mmio_spte_mask(mask, PT_WRITABLE_MASK | PT_USER_MASK); > > > > The call in the original upstream patch was: > > > > kvm_mmu_set_mmio_spte_mask(mask, mask, PT_WRITABLE_MASK | PT_USER_MASK); > > Greg, > > I should have asked in the earlier email... how do you want to address this? I will fix this up now, thanks for pointing out what I got wrong... greg k-h
