Re: [PATCH v4.14] ASoC: topology: Fix memleak in soc_tplg_manifest_load()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 10, 2020 at 04:02:11PM +0200, Dragos Tarcatu wrote:
> commit 242c46c023610dbc0213fc8fb6b71eb836bc5d95 upstream.
> 
> In case of ABI version mismatch, _manifest needs to be freed as
> it is just a copy of the original topology manifest. However, if
> a driver manifest handler is defined, that would get executed and
> the cleanup is never reached. Fix that by getting the return status
> of manifest() instead of returning directly.
> 
> Fixes: 583958fa2e52 ("ASoC: topology: Make manifest backward compatible from ABI v4")
> Signed-off-by: Dragos Tarcatu <dragos_tarcatu@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20200207185325.22320-3-dragos_tarcatu@xxxxxxxxxx
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> ---
>  sound/soc/soc-topology.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Thanks for the backport, now queued up.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux