From: Nathan Chancellor > Sent: 10 March 2020 01:26 ... > Sure, I can send v2 to do that but I think that sending 97 patches just > casting the small values (usually less than twenty) to unsigned long > then to the enum is rather frivolous. I audited at least ten to fifteen > of these call sites when creating the clang patch and they are all > basically false positives. Such casts just make the code hard to read. If misused casts can hide horrid bugs. IMHO sprinkling the code with casts just to remove compiler warnings will bite back one day. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
