On 09.03.20 16:39, David Hildenbrand wrote:
> On 09.03.20 16:00, Christian Borntraeger wrote:
>> When we do the initial CPU reset we must not only clear the registers
>> in the internal data structures but also in kvm_run sync_regs. For
>> modern userspace sync_regs is the only place that it looks at.
>>
>> Cc: stable@xxxxxxxxxxxxxxx
>> Fixes: 7de3f1423ff943 ("KVM: s390: Add new reset vcpu API")
>> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
>> ---
>> arch/s390/kvm/kvm-s390.c | 18 +++++++++++++++++-
>> 1 file changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 6b1842a9feed..81f54ddedb3d 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -3529,7 +3529,10 @@ static void kvm_arch_vcpu_ioctl_initial_reset(struct kvm_vcpu *vcpu)
>> /* Initial reset is a superset of the normal reset */
>> kvm_arch_vcpu_ioctl_normal_reset(vcpu);
>>
>> - /* this equals initial cpu reset in pop, but we don't switch to ESA */
>> + /*
>> + * This equals initial cpu reset in pop, but we don't switch to ESA.
>> + * We do not even reset the internal data, but also ...
>
> s/even/only ?
ack and fixed. I will give this series some time but it might be worthwile still for 5.6 (even
with the tests).
