On Sun, Mar 08, 2020 at 08:51:12PM -0400, Sasha Levin wrote:
> On Sun, Mar 08, 2020 at 02:51:27PM -0700, Kees Cook wrote:
> > On Sat, Mar 07, 2020 at 11:20:37PM +0000, Sasha Levin wrote:
> > > Hi
> > >
> > > [This is an automated email]
> > >
> > > This commit has been processed because it contains a "Fixes:" tag
> > > fixing commit: 2482ddec670f ("mm: add SLUB free list pointer obfuscation").
> > >
> > > The bot has tested the following trees: v5.5.8, v5.4.24, v4.19.108, v4.14.172.
> > >
> > > v5.5.8: Build failed! Errors:
> > > mm/slub.c:262:4: error: implicit declaration of function ‘swab’; did you mean ‘swap’? [-Werror=implicit-function-declaration]
> > >
> >
> > Eek; this must be missing an include that is implicit from something
> > recent? I will investigate...
>
> swab() didn't exist "back then" :) It was introduced by d5767057c9a7
> ("uapi: rename ext2_swab() to swab() and share globally in swab.h"). I
> can just take that patch to stable kernels.
Ah, perfect. Yes, that would be very nice.
--
Kees Cook
