Re: 5.5.y - apply "ASoC: intel/skl/hda - export number of digital microphones via control components"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




This looks more like a new feature than a bug fix and I've been trying
to get the stable people to calm down with the backports, there's been
*far* too many regressions introduced recently in just the x86 stuff
found after the fact.  Does this fix systems that used to work?

The released ALSA UCM does not work correctly for some platforms without
this information (the number of digital microphones is not identified
correctly).

That's not the question I asked - have these platforms ever worked with
older kernel versions?

Yes in that digital microphones have been enabled for a very long time (5.2 if I am not mistaken).

No in that the automatic selection of the SOF driver was only enabled for v5.5. In other words before 5.5 the user or distro needed to blacklist the legacy snd-hda-intel HDAudio driver to get DMICs to work.

This patch also removes the need for userspace configuration, pulseaudio now directly receives the information on the number of microphones. It was provided days after the merge window was opened, but the intent was that v5.5 was the first release where users don't need to muck with configuration files.

The regression probability is really low for this one and we're using it in
Fedora kernels for months without issues (in this code).

It's partly the principle of the thing, if it were just patches that
had individually been identified as being good for stable by someone
with some understanding of the code (like this one :/ ) that were being
backported I'd be a lot less concerned but the automated selections are
missing dependencies or other context and people are reporting problems
with them so I'm inclined to push back on things.

You are correct that the process can appear confusing, mainly since the initial patch was contributed after the merge window on November 26.

Looking back at the emails, I didn't see any objections but somehow the patch never landed in 5.5 updates. Jaroslav's intentions and work are not without merit, we really appreciate his ucm2 work, and I support this integration on v5.5-y to make the life of downstream distros simpler.

Would it help if we provide a Tested-by tag with 5.5-y + this patch applied?

Thanks
-Pierre



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux