On 03/03/2020 14:27, Alexander Sverdlin wrote:
Hi Alexander,
On 02/03/2020 19:25, John Garry wrote:
- { "s25fl129p1", INFO(0x012018, 0x4d01, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },
+ { "s25fl129p1", INFO(0x012018, 0x4d01, 64 * 1024, 256, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR)
+ .fixups = &s25fs_s_fixups, },
It seems SFDP is not supported on s25fl129p (you can check it on https://www.cypress.com/file/400586/download), so is it necessary to add this for this type flash?
Yes, all of the above is necessary to repair S25FS128S, which supports SFDP and lands
in the above table entry.
So do you know how we can tell if the part is s25fl129p1 or S25FS128S? Is it based on family id? For the part of my board, it has the same id according to "s25fl129p1" entry in the spi-nor driver, yet the SFDP signature is not present (signature reads as 0x4d182001 vs expected 0x50444653). I printed the family id, and it is 81h, which seems to align with S25FS (which should support SFDP). Confused.
What's more, the spi-nor probe is failing for this part since I enabled quad spi. So I am interested to know if there is some differences between these part families for that.
I'd say, one can distinguish them by the fact one does support SFDP and another doesn't.
Is it really necessary to distinguish them?
Well it would help me to know for sure which part is on my board :)
As an example of a relevant difference, S25FS128S datasheet has CR1V and
CR1NV, but S25FL129 only has a single configuration register, and this
is related to quad mode enable, which I am debugging.
BTW, Have you tried to enable quad mode for your S25FS-S part?
Thanks,
John
