On Thu, Feb 20, 2020 at 09:16:51AM +0000, Ben Hutchings wrote: > On Sun, 2020-02-09 at 15:12 -0500, Sasha Levin wrote: > > On Sun, Feb 09, 2020 at 01:31:58PM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > > The patch below does not apply to the 4.19-stable tree. > > > If someone wants it applied there, or to any other stable or longterm > > > tree, then please email the backport, including the original git commit > > > id to <stable@xxxxxxxxxxxxxxx>. > > > > > > thanks, > > > > > > greg k-h > > > > > > ------------------ original commit in Linus's tree ------------------ > > > > > > From fe6ed369fca98e99df55c932b85782a5687526b5 Mon Sep 17 00:00:00 2001 > > > From: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > > Date: Tue, 10 Dec 2019 15:24:32 -0800 > > > Subject: [PATCH] KVM: VMX: Add non-canonical check on writes to RTIT address > > > MSRs > > > > > > Reject writes to RTIT address MSRs if the data being written is a > > > non-canonical address as the MSRs are subject to canonical checks, e.g. > > > KVM will trigger an unchecked #GP when loading the values to hardware > > > during pt_guest_enter(). > > > > > > Cc: stable@xxxxxxxxxxxxxxx > > > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > > Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > > > > File/code movement. Cleaned up and queued for 4.19-4.4. > > I don't know what happened here, but you've ended up adding the > entirety of arch/x86/kvm/vmx/vmx.c on all those branches rather than > applying the change to the right file. Oh wow that's wrong :( I'll go revert this, as it's not actually doing anything. Thanks for catching this. greg k-h