Re: [PATCH v2] mtd: spi-nor: Fixup page size for S25FS-S

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/02/2020 04:53, Vignesh Raghavendra wrote:
I don't mean to hijack this thread, but I have tried to enable QUAD mode
for part s25fl129p1, and it fails in spi_nor_write_16bit_cr_and_check():

[ 47.263365] spi-nor spi-PRP0001:00: CR: read back test failed
[ 47.306567] spi-nor spi-PRP0001:00: quad mode not supported
[ 47.322413] spi-nor: probe of spi-PRP0001:00 failed with error -5

Hacking the flags to set SNOR_F_NO_READ_CR, and at least I can
successfully probe the driver.

Does anyone know if this part does not support reading the config
register. The limited datasheet here doesn't mention it, AFAICT:


Hi Vignesh,

https://www.cypress.com/file/196851/download
Above datasheet is for s25fl128p.


Right, I figured this out soon enough. I shouldn't just click on the first page which google produces...

Per, s25fl129p datasheet[1], part does support 0x35 (SPINOR_OP_RDCR)
command and support 16bit write status register command (0x1)

Could you debug further and see what exactly fails to match when
read back fails?

I was trying to figure out the issue. So in spi_nor_write_16bit_cr_and_check(), the sr check passes (it holds 0, so that may be somewhat inconclusive) but the value for comparison return 0 in the CR also versus expected 3.

Maybe it is a host driver issue, but I am doubtful.

I can continue to investigate. Any ideas would be appreciated.


[1]https://www.cypress.com/file/197121/download



Thanks,
John




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux