On Fri, Feb 14, 2020 at 10:43:12AM -0500, Sasha Levin wrote: > From: Xiongfeng Wang <wangxiongfeng2@xxxxxxxxxx> > > [ Upstream commit 94345aee285334e9e12fc70572e3d9380791a64e ] > > Fix the following warning: > drivers/tty/serial/amba-pl011.c: In function check_apply_cts_event_workaround: > drivers/tty/serial/amba-pl011.c:1461:15: warning: variable dummy_read set but not used [-Wunused-but-set-variable] > > The data read is useless and can be dropped. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@xxxxxxxxxx> > Link: https://lore.kernel.org/r/1575619526-34482-1-git-send-email-wangxiongfeng2@xxxxxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > --- > drivers/tty/serial/amba-pl011.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c > index 4b28134d596a9..c5e9475feb47a 100644 > --- a/drivers/tty/serial/amba-pl011.c > +++ b/drivers/tty/serial/amba-pl011.c > @@ -1452,8 +1452,6 @@ static void pl011_modem_status(struct uart_amba_port *uap) > > static void check_apply_cts_event_workaround(struct uart_amba_port *uap) > { > - unsigned int dummy_read; > - > if (!uap->vendor->cts_event_workaround) > return; > > @@ -1465,8 +1463,8 @@ static void check_apply_cts_event_workaround(struct uart_amba_port *uap) > * single apb access will incur 2 pclk(133.12Mhz) delay, > * so add 2 dummy reads > */ > - dummy_read = pl011_read(uap, REG_ICR); > - dummy_read = pl011_read(uap, REG_ICR); > + pl011_read(uap, REG_ICR); > + pl011_read(uap, REG_ICR); > } > > static irqreturn_t pl011_int(int irq, void *dev_id) > -- > 2.20.1 > Please drop.
