On Wed, 22 Jan 2020 02:26:22 +0000
Sasha Levin <sashal@xxxxxxxxxx> wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: 30350d65ac56 ("tracing: Add variable support to hist triggers").
>
> The bot has tested the following trees: v5.4.13, v4.19.97.
>
> v5.4.13: Build OK!
> v4.19.97: Build failed! Errors:
> kernel/trace/trace_events_hist.c:5725:34: error: macro "list_for_each_entry_rcu" passed 4 arguments, but takes just 3
> kernel/trace/trace_events_hist.c:5724:2: error: ‘list_for_each_entry_rcu’ undeclared (first use in this function)
> kernel/trace/trace_events_hist.c:5724:25: error: expected ‘;’ before ‘{’ token
Ah, that depends on commit 28875945ba98 ("rcu: Add support for consolidated-RCU reader checking").
We need to remove lockdep_is_held() from that list_for_each_entry_rcu().
(I've attached it)
Thank you,
--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>
Attachment:
tracing-trigger-replace
Description: Binary data
