Re: [PATCH 1/7] tracing: Initialize val to zero in parse_entry of inject code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Why am I receiving these?

-- Steve


On Mon, 20 Jan 2020 16:36:16 +0000
Jules Irenge <jbi.octave@xxxxxxxxx> wrote:

> From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
> 
> gcc produces a variable may be uninitialized warning for "val" in
> parse_entry(). This is really a false positive, but the code is subtle
> enough to just initialize val to zero and it's not a fast path to worry
> about it.
> 
> Marked for stable to remove the warning in the stable trees as well.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 6c3edaf9fd6a3 ("tracing: Introduce trace event injection")
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> ---
>  kernel/trace/trace_events_inject.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_events_inject.c b/kernel/trace/trace_events_inject.c
> index d45079ee62f8..22bcf7c51d1e 100644
> --- a/kernel/trace/trace_events_inject.c
> +++ b/kernel/trace/trace_events_inject.c
> @@ -195,7 +195,7 @@ static int parse_entry(char *str, struct trace_event_call *call, void **pentry)
>  	unsigned long irq_flags;
>  	void *entry = NULL;
>  	int entry_size;
> -	u64 val;
> +	u64 val = 0;
>  	int len;
>  
>  	entry = trace_alloc_entry(call, &entry_size);




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux