RE: [LINUX PATCH] ubifs: Fix wrong memory allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Please ignore this.

Thanks,
Naga Sureshkumar Relli

> -----Original Message-----
> From: Naga Sureshkumar Relli <naga.sureshkumar.relli@xxxxxxxxxx>
> Sent: Thursday, January 9, 2020 12:23 PM
> To: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Subject: [LINUX PATCH] ubifs: Fix wrong memory allocation
> 
> From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> 
> In create_default_filesystem() when we allocate the idx node we must use the idx_node_size we
> calculated just one line before, not tmp, which contains completely other data.
> 
> Fixes: c4de6d7e4319 ("ubifs: Refactor create_default_filesystem()")
> Cc: stable@xxxxxxxxxxxxxxx # v4.20+
> Reported-by: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>
> Tested-by: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> ---
>  fs/ubifs/sb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ubifs/sb.c b/fs/ubifs/sb.c index a551eb3e9b89..6681c18e52b8 100644
> --- a/fs/ubifs/sb.c
> +++ b/fs/ubifs/sb.c
> @@ -161,7 +161,7 @@ static int create_default_filesystem(struct ubifs_info *c)
>  	sup = kzalloc(ALIGN(UBIFS_SB_NODE_SZ, c->min_io_size), GFP_KERNEL);
>  	mst = kzalloc(c->mst_node_alsz, GFP_KERNEL);
>  	idx_node_size = ubifs_idx_node_sz(c, 1);
> -	idx = kzalloc(ALIGN(tmp, c->min_io_size), GFP_KERNEL);
> +	idx = kzalloc(ALIGN(idx_node_size, c->min_io_size), GFP_KERNEL);
>  	ino = kzalloc(ALIGN(UBIFS_INO_NODE_SZ, c->min_io_size), GFP_KERNEL);
>  	cs = kzalloc(ALIGN(UBIFS_CS_NODE_SZ, c->min_io_size), GFP_KERNEL);
> 
> --
> 2.17.1





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux