Re: [PATCH v5.4] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2020-01-01 at 18:02 +0100, Greg KH wrote:
> On Mon, Dec 23, 2019 at 02:56:12PM +0200, Luca Coelho wrote:
> > From: Anders Kaseorg <andersk@xxxxxxx>
> > 
> > This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99.
> > 
> > Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4
> > attempted to fix the same bug (dead assignments to the local variable
> > cfg), but they did so in incompatible ways. When they were both merged,
> > independently of each other, the combination actually caused the bug to
> > reappear, leading to a firmware crash on boot for some cards.
> > 
> > https://bugzilla.kernel.org/show_bug.cgi?id=205719
> > 
> > Signed-off-by: Anders Kaseorg <andersk@xxxxxxx>
> > Acked-by: Luca Coelho <luciano.coelho@xxxxxxxxx>
> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> > ---
> >  drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 24 +++++++++----------
> >  1 file changed, 12 insertions(+), 12 deletions(-)
> > 
> 
> Next time a hint as to what this git commit id is in Linus's tree would
> be nice :)

Oh, right.  I'm sorry, I completely forgot it...

--
Luca.




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux