On Wed, 2019-12-11 at 16:17 -0700, Jerry Snitselaar wrote: > Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when > issuing commands to the tpm during initialization, just reserve the > chip after wait_startup, and release it when we are ready to call > tpm_chip_register. > > Cc: Christian Bundy <christianbundy@xxxxxxxxxxx> > Cc: Dan Williams <dan.j.williams@xxxxxxxxx> > Cc: Peter Huewe <peterhuewe@xxxxxx> > Cc: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > Cc: Jason Gunthorpe <jgg@xxxxxxxx> > Cc: Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Cc: linux-intergrity@xxxxxxxxxxxxxxx > Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") > Signed-off-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx> Sorry for the latency. For me this looks good for putting to my rc3 PR with a minor twist: 1. Rename out_err as err_probe. 2. Rename out_start as err_start. /Jarkko