This is a note to let you know that I've just added the patch titled
NFSv4: Fix a slot leak in nfs40_sequence_done
to the 3.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
nfsv4-fix-a-slot-leak-in-nfs40_sequence_done.patch
and it can be found in the queue-3.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From cab92c19821a814ecf5a5279e2699bf28e66caee Mon Sep 17 00:00:00 2001
From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
Date: Wed, 29 Jan 2014 12:12:15 -0500
Subject: NFSv4: Fix a slot leak in nfs40_sequence_done
From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
commit cab92c19821a814ecf5a5279e2699bf28e66caee upstream.
The check for whether or not we sent an RPC call in nfs40_sequence_done
is insufficient to decide whether or not we are holding a session slot,
and thus should not be used to decide when to free that slot.
This patch replaces the RPC_WAS_SENT() test with the correct test for
whether or not slot == NULL.
Cc: Chuck Lever <chuck.lever@xxxxxxxxxx>
Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/nfs/nfs4proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -532,7 +532,7 @@ static int nfs40_sequence_done(struct rp
struct nfs4_slot *slot = res->sr_slot;
struct nfs4_slot_table *tbl;
- if (!RPC_WAS_SENT(task))
+ if (slot == NULL)
goto out;
tbl = slot->table;
Patches currently in stable-queue which might be from trond.myklebust@xxxxxxxxxxxxxxx are
queue-3.12/nfsv4-fix-a-slot-leak-in-nfs40_sequence_done.patch
queue-3.12/nfs4.1-properly-handle-enotsup-in-secinfo_no_name.patch
queue-3.12/pnfs-proper-delay-for-nfs4err_recallconflict-in-layout_get_done.patch
queue-3.12/nfs-always-make-sure-page-is-up-to-date-before-extending-a-write-to-cover-the-entire-page.patch
queue-3.12/nfsv4-open-must-handle-the-nfs4err_io-return-code-correctly.patch
queue-3.12/sunrpc-fix-infinite-loop-in-rpc-state-machine.patch
queue-3.12/nfs4-fix-discover_server_trunking-use-after-free.patch
queue-3.12/nfsv4.1-handle-errors-correctly-in-nfs41_walk_client_list.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html