Re: WTF: patch "[PATCH] net: wireless: ti: wl1251 add device tree support" was seriously submitted to be applied to the 5.4-stable tree?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,
I have checked with Documentation/process/stable-kernel-rules.rst but not found out
what is failing.

Basically this belongs to a series to fix a bug

81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel")

that exists since v4.7 and has been hidden by patches which came into the kernel over
the time.

BR and thanks,
Nikolaus Schaller

> Am 11.12.2019 um 15:06 schrieb <gregkh@xxxxxxxxxxxxxxxxxxx> <gregkh@xxxxxxxxxxxxxxxxxxx>:
> 
> The patch below was submitted to be applied to the 5.4-stable tree.
> 
> I fail to see how this patch meets the stable kernel rules as found at
> Documentation/process/stable-kernel-rules.rst.
> 
> I could be totally wrong, and if so, please respond to 
> <stable@xxxxxxxxxxxxxxx> and let me know why this patch should be
> applied.  Otherwise, it is now dropped from my patch queues, never to be
> seen again.
> 
> thanks,
> 
> greg k-h
> 
> ------------------ original commit in Linus's tree ------------------
> 
> From 9b8d7072d6552ee5c57e5765f211f267041f9557 Mon Sep 17 00:00:00 2001
> From: "H. Nikolaus Schaller" <hns@xxxxxxxxxxxxx>
> Date: Thu, 7 Nov 2019 11:30:35 +0100
> Subject: [PATCH] net: wireless: ti: wl1251 add device tree support
> 
> We will have the wl1251 defined as a child node of the mmc interface
> and can read setup for gpios, interrupts and the ti,use-eeprom
> property from there instead of pdata to be provided by pdata-quirks.
> 
> Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel")
> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> Acked-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v4.7+
> [Ulf: Fixed up some complaints from checkpatch]
> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> 
> diff --git a/drivers/net/wireless/ti/wl1251/sdio.c b/drivers/net/wireless/ti/wl1251/sdio.c
> index 677f1146ccf0..f1224b948f83 100644
> --- a/drivers/net/wireless/ti/wl1251/sdio.c
> +++ b/drivers/net/wireless/ti/wl1251/sdio.c
> @@ -16,6 +16,9 @@
> #include <linux/irq.h>
> #include <linux/pm_runtime.h>
> #include <linux/gpio.h>
> +#include <linux/of.h>
> +#include <linux/of_gpio.h>
> +#include <linux/of_irq.h>
> 
> #include "wl1251.h"
> 
> @@ -217,6 +220,7 @@ static int wl1251_sdio_probe(struct sdio_func *func,
> 	struct ieee80211_hw *hw;
> 	struct wl1251_sdio *wl_sdio;
> 	const struct wl1251_platform_data *wl1251_board_data;
> +	struct device_node *np = func->dev.of_node;
> 
> 	hw = wl1251_alloc_hw();
> 	if (IS_ERR(hw))
> @@ -248,6 +252,17 @@ static int wl1251_sdio_probe(struct sdio_func *func,
> 		wl->power_gpio = wl1251_board_data->power_gpio;
> 		wl->irq = wl1251_board_data->irq;
> 		wl->use_eeprom = wl1251_board_data->use_eeprom;
> +	} else if (np) {
> +		wl->use_eeprom = of_property_read_bool(np,
> +						       "ti,wl1251-has-eeprom");
> +		wl->power_gpio = of_get_named_gpio(np, "ti,power-gpio", 0);
> +		wl->irq = of_irq_get(np, 0);
> +
> +		if (wl->power_gpio == -EPROBE_DEFER ||
> +		    wl->irq == -EPROBE_DEFER) {
> +			ret = -EPROBE_DEFER;
> +			goto disable;
> +		}
> 	}
> 
> 	if (gpio_is_valid(wl->power_gpio)) {
> 





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux