On Tue, Dec 10, 2019 at 05:02:52PM -0500, Sasha Levin wrote: > From: Kusanagi Kouichi <slash@xxxxxxxxxxxxxxx> > > [ Upstream commit 4250b047039d324e0ff65267c8beb5bad5052a86 ] > > If DEBUG_FS=n, compile fails with the following error: > > kernel/trace/trace.c: In function 'tracing_init_dentry': > kernel/trace/trace.c:8658:9: error: passing argument 3 of 'debugfs_create_automount' from incompatible pointer type [-Werror=incompatible-pointer-types] > 8658 | trace_automount, NULL); > | ^~~~~~~~~~~~~~~ > | | > | struct vfsmount * (*)(struct dentry *, void *) > In file included from kernel/trace/trace.c:24: > ./include/linux/debugfs.h:206:25: note: expected 'struct vfsmount * (*)(void *)' but argument is of type 'struct vfsmount * (*)(struct dentry *, void *)' > 206 | struct vfsmount *(*f)(void *), > | ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ > > Signed-off-by: Kusanagi Kouichi <slash@xxxxxxxxxxxxxxx> > Link: https://lore.kernel.org/r/20191121102021787.MLMY.25002.ppp.dion.ne.jp@xxxxxxxxxxxxxxxxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > --- > include/linux/debugfs.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Not needed, please drop from everywhere. thanks, greg k-h