On Fri, 6 Dec 2019, Yang Shi wrote:
> Felix Abecassis reports move_pages() would return random status if the
> pages are already on the target node by the below test program:
Looks ok.
Acked-by: Christoph Lameter <cl@xxxxxxxxx>
Nitpicks:
> @@ -1553,7 +1555,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr,
> if (PageHuge(page)) {
> if (PageHead(page)) {
> isolate_huge_page(page, pagelist);
> - err = 0;
> + err = 1;
Add a meaningful constant instead of 1?
> out:
> up_read(&mm->mmap_sem);
> +
> return err;
Dont do that.
