Re: [v2 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node

[John Hubbard <jhubbard@xxxxxxxxxx>]

On 12/4/19 9:44 PM, John Hubbard wrote:
...           */
> Let's change the comment above add_page_for_migration(), to read:
>
>          /*
>           * Most errors in the page lookup or isolation are not fatal
>           * and we simply report them via the status array. However,
>           * positive error values are fatal.
>           */
>
>
> >           err = add_page_for_migration(mm, addr, current_node,
> > -                &pagelist, flags & MPOL_MF_MOVE_ALL);
> > +                &pagelist, flags & MPOL_MF_MOVE_ALL, status,
> > +                i);
> > +
> >           if (!err)
> >               continue;
> > +        /* store_status() failed in add_page_for_migration() */
>
> ...and let's replace the above line, with the following:

Correction, I experienced a fatal editor copy-paste mistake here. :) I meant to
suggest this:

		/*
		 * add_page_for_migration() experienced a fatal failure (see the
		 * comments in that routine for details).
		 */

> > +        if (err > 0) {
> > +            err = -EFAULT;
> > +            goto out_flush;
> > +        }
> > +
> >           err = store_status(status, i, err, 1);
> >           if (err)
> >               goto out_flush;

thanks,
--
John Hubbard
NVIDIA