Hi Felipe, Felipe Balbi wrote: > Hi, > > Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> writes: > >> The function driver may try to enable an unconfigured endpoint. This >> check make sure that we do not attempt to access a NULL descriptor and >> crash. >> >> Cc: stable@xxxxxxxxxxxxxxx >> Signed-off-by: Thinh Nguyen <thinhn@xxxxxxxxxxxx> >> --- >> drivers/usb/dwc3/gadget.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 7f97856e6b20..00f8f079bbf2 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++ b/drivers/usb/dwc3/gadget.c >> @@ -619,6 +619,9 @@ static int __dwc3_gadget_ep_enable(struct dwc3_ep *dep, unsigned int action) >> u32 reg; >> int ret; >> >> + if (!desc) >> + return -EINVAL; > I would rather have a dev_WARN() (and return -EINVAL) added to > usb_ep_enable() so we catch those doing this. That way we don't have to > patch every UDC. > Sure, we can do that. Thanks, Thinh
