On 2019/11/27, Thomas Zimmermann wrote: > Hi Emil > > Am 27.11.19 um 17:29 schrieb Emil Velikov: > > Hi Thomas, > > > > On Tue, 26 Nov 2019 at 10:15, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > >> > >> Adds a conversion function that extracts the device type from the > >> PCI id-table flags. Allows for storing additional information in the > >> other flag bits. > >> > >> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > >> Fixes: 81da87f63a1e ("drm: Replace drm_gem_vram_push_to_system() with kunmap + unpin") > > > > Are you sure the fixes tag is correct? Neither the commit summary nor > > the patch itself seems related to the changes below. > > Yes, it's correct. It's part of a patch series [1][2][3] that fixes the bug. > > Best regards > Thomas > > [1] > https://cgit.freedesktop.org/drm/drm-tip/commit/?id=3a8a5aba142a44eaeba0cb0ec1b4a8f177b5e59a > [2] > https://cgit.freedesktop.org/drm/drm-tip/commit/?id=d6d437d97d54c85a1a93967b2745e31dff03365a > [3] > https://cgit.freedesktop.org/drm/drm-tip/commit/?id=1591fadf857cdbaf2baa55e421af99a61354713c > I see, different alignment is required for one mga200 GPU. Personally, I would have mentioned that in the commit message. Regardless, hats off for the prompt fixup. Thanks Emil