On Wed, Nov 27, 2019 at 07:22:09AM +0000, Lee Jones wrote:
> From: Wen Yang <wen.yang99@xxxxxxxxxx>
>
> [ Upstream commit 0f4bb10857e22a657e6c8cca5d1d54b641e94628 ]
>
> kmemdup has implemented the function that kmalloc() + memcpy().
> We prefer to kmemdup rather than code opened implementation.
>
> This issue was detected with the help of coccinelle.
>
> Signed-off-by: Wen Yang <wen.yang99@xxxxxxxxxx>
> CC: Tomoki Sekiyama <tomoki.sekiyama@xxxxxxxxx>
> CC: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/media/usb/siano/smsusb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/siano/smsusb.c b/drivers/media/usb/siano/smsusb.c
> index 3071d9bc77f4..38ea773eac97 100644
> --- a/drivers/media/usb/siano/smsusb.c
> +++ b/drivers/media/usb/siano/smsusb.c
> @@ -225,10 +225,9 @@ static int smsusb_sendrequest(void *context, void *buffer, size_t size)
> return -ENOENT;
> }
>
> - phdr = kmalloc(size, GFP_KERNEL);
> + phdr = kmemdup(buffer, size, GFP_KERNEL);
> if (!phdr)
> return -ENOMEM;
> - memcpy(phdr, buffer, size);
>
> pr_debug("sending %s(%d) size: %d\n",
> smscore_translate_msg(phdr->msg_type), phdr->msg_type,
> --
> 2.24.0
>
Why does this patch qualify for stable inclusion?
