On Tue, Nov 26, 2019 at 06:28:29PM +0100, Greg KH wrote: > On Tue, Nov 26, 2019 at 12:05:50PM -0500, Mike Snitzer wrote: > > On Tue, Nov 26 2019 at 5:41am -0500, > > gregkh@xxxxxxxxxxxxxxxxxxx <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > The patch below does not apply to the 4.19-stable tree. > > > If someone wants it applied there, or to any other stable or longterm > > > tree, then please email the backport, including the original git commit > > > id to <stable@xxxxxxxxxxxxxxx>. > > > > > > thanks, > > > > > > greg k-h > > > > > > > I assume you didn't first pull in the prereq commit detailed in the > > commit header with: > > Requires: ed0302e83098d ("dm crypt: make workqueue names device-specific") > > > > ? > > > > Because this worked for me: > > git cherry-pick ed0302e83098d > > git cherry-pick f612b2132db529feac4f965f28a1b9258ea7c22b > > Oops, missed that, will go try that now, sorry for the noise... Nope, that did not work, the build breaks on both 4.14.y and 4.19.y: drivers/md/dm-crypt.c: In function ‘crypt_ctr’: drivers/md/dm-crypt.c:2674:24: error: implicit declaration of function ‘dm_table_device_name’; did you mean ‘dm_device_name’? [-Werror=implicit-function-declaration] 2674 | const char *devname = dm_table_device_name(ti->table); | ^~~~~~~~~~~~~~~~~~~~ | dm_device_name So we need working backports for 4.14.y and 4.19.y please. I'm going to go drop these patches from those queues now. thanks, greg k-h