On Thu, 2019-11-21 at 15:04 +0100, Arnd Bergmann wrote: [...] > As Greg has already merged the original patch, and that version works > just as well, I'd probably just leave what I did at first. One benefit is > that in case we decide to kill off sparc64 support before drivers/char/lp.c, > the special case can be removed more easily. > > I don't think either of them is going any time soon, but working on y2038 > patches has made me think ahead longer term ;-) > > If you still think we should change it I can send the below patch (now > actually build-tested) with your Ack. [...] I would like it, but since you convinced me the current version works correctly it's obvious lower priority than the other changes you have. Ben. -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom