On Wed, Nov 20, 2019 at 10:59:05PM +0100, Pavel Machek wrote: > On Tue 2019-11-19 06:14:22, Greg Kroah-Hartman wrote: > > From: Anirudh Venkataramanan <anirudh.venkataramanan@xxxxxxxxx> > > > > [ Upstream commit 9ea47d81a7f17c6b77211ab75fbca2127719ad39 ] > > > > Remove the "ice" prefix for the driver version string and bump version > > to 0.7.1-k. > > This sounds like a bad idea. 0.7.1 in mainline contains patches that > were not backported to stable, so marking this as 0.7.1 version is > wrong. > > Best regards, > Pavel > > > +++ b/drivers/net/ethernet/intel/ice/ice_main.c > > @@ -7,7 +7,7 @@ > > > > #include "ice.h" > > > > -#define DRV_VERSION "ice-0.7.0-k" > > +#define DRV_VERSION "0.7.1-k" Hah, this is why "versions" for drivers are totally meaningless and why we removed them from most of the kernel tree already. I recommend doing that here as well. thanks, greg k-h
