On Tue 2019-11-19 06:19:09, Greg Kroah-Hartman wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > > [ Upstream commit 1830dad34c070161fda2ff1db77b39ffa78aa380 ] > > Move ngd platform driver out of loop so that it registers only once. AFAICT driver_register is immediately followed by "return", so it was already registered only once before you patched it. I don't think this should be in stable. Best regards, Pavel > +++ b/drivers/slimbus/qcom-ngd-ctrl.c > @@ -1346,7 +1346,6 @@ static int of_qcom_slim_ngd_register(struct device *parent, > ngd->base = ctrl->base + ngd->id * data->offset + > (ngd->id - 1) * data->size; > ctrl->ngd = ngd; > - platform_driver_register(&qcom_slim_ngd_driver); > > return 0; > } > @@ -1445,6 +1444,7 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) > init_completion(&ctrl->reconf); > init_completion(&ctrl->qmi.qmi_comp); > > + platform_driver_register(&qcom_slim_ngd_driver); > return of_qcom_slim_ngd_register(dev, ctrl); > } > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
