Hello, On Wed, 5 Feb 2014, Julian Anastasov wrote: > On Wed, 5 Feb 2014, Paul Gortmaker wrote: > > > From: Mathias Krause <minipli@xxxxxxxxxxxxxx> > > > > ------------------- > > This is a commit scheduled for the next v2.6.34 longterm release. > > http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git > > If you see a problem with using this for longterm, please comment. > > ------------------- > > > > commit 2d8a041b7bfe1097af21441cb77d6af95f4f4680 upstream. > > > > If at least one of CONFIG_IP_VS_PROTO_TCP or CONFIG_IP_VS_PROTO_UDP is > > not set, __ip_vs_get_timeouts() does not fully initialize the structure > > that gets copied to userland and that for leaks up to 12 bytes of kernel > > stack. Add an explicit memset(0) before passing the structure to > > __ip_vs_get_timeouts() to avoid the info leak. > > I guess, this patch is not needed after commit > "ipvs: initialize returned data in do_ip_vs_get_ctl" because > the memset is already moved into __ip_vs_get_timeouts(). Sorry, I thought this patch comes after commit b61a602ee6730150f4d0df730d9312ac4d820ceb ("ipvs: initialize returned data in do_ip_vs_get_ctl") but it looks like it is ok with this single change, sorry for the noise! Regards -- Julian Anastasov <ja@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html