Re: [PATCH] nl80211: fix validation of mesh path nexthop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 04, 2019 at 10:00:16AM +0100, Markus Theil wrote:
> commit 1fab1b89e2e8f01204a9c05a39fd0b6411a48593 upstream.
> 
> Mesh path nexthop should be a ethernet address, but current validation
> checks against 4 byte integers.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 2ec600d672e74 ("nl80211/cfg80211: support for mesh, sta dumping")
> Signed-off-by: Markus Theil <markus.theil@xxxxxxxxxxxxx>
> ---
>  net/wireless/nl80211.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 105fdd8589d7..a9df1301436e 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -259,7 +259,8 @@ static const struct nla_policy nl80211_policy[NL80211_ATTR_MAX+1] = {
>  	[NL80211_ATTR_MNTR_FLAGS] = { /* NLA_NESTED can't be empty */ },
>  	[NL80211_ATTR_MESH_ID] = { .type = NLA_BINARY,
>  				   .len = IEEE80211_MAX_MESH_ID_LEN },
> -	[NL80211_ATTR_MPATH_NEXT_HOP] = { .type = NLA_U32 },
> +	[NL80211_ATTR_MPATH_NEXT_HOP] = { .type = NLA_BINARY,
> +					  .len = ETH_ALEN },
>  
>  	[NL80211_ATTR_REG_ALPHA2] = { .type = NLA_STRING, .len = 2 },
>  	[NL80211_ATTR_REG_RULES] = { .type = NLA_NESTED },

Many thanks for the backport, now queued up.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux