On 2019/10/28 下午11:21, Sasha Levin wrote:
> On Sun, Oct 27, 2019 at 04:48:16PM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
>>
>> The patch below does not apply to the 4.19-stable tree.
>> If someone wants it applied there, or to any other stable or longterm
>> tree, then please email the backport, including the original git commit
>> id to <stable@xxxxxxxxxxxxxxx>.
>>
>> thanks,
>>
>> greg k-h
>>
>> ------------------ original commit in Linus's tree ------------------
>>
>> From fd2b007eaec898564e269d1f478a2da0380ecf51 Mon Sep 17 00:00:00 2001
>> From: Qu Wenruo <wqu@xxxxxxxx>
>> Date: Thu, 17 Oct 2019 10:38:36 +0800
>> Subject: [PATCH] btrfs: tracepoints: Fix wrong parameter order for qgroup
>> events
>>
>> [BUG]
>> For btrfs:qgroup_meta_reserve event, the trace event can output garbage:
>>
>> qgroup_meta_reserve: 9c7f6acc-b342-4037-bc47-7f6e4d2232d7:
>> refroot=5(FS_TREE) type=DATA diff=2
>>
>> The diff should always be alinged to sector size (4k), so there is
>> definitely something wrong.
>>
>> [CAUSE]
>> For the wrong @diff, it's caused by wrong parameter order.
>> The correct parameters are:
>>
>> struct btrfs_root, s64 diff, int type.
>>
>> However the parameters used are:
>>
>> struct btrfs_root, int type, s64 diff.
>>
>> Fixes: 4ee0d8832c2e ("btrfs: qgroup: Update trace events for metadata
>> reservation")
>> CC: stable@xxxxxxxxxxxxxxx # 4.19+
>> Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>
>> Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>
>> Reviewed-by: David Sterba <dsterba@xxxxxxxx>
>> Signed-off-by: David Sterba <dsterba@xxxxxxxx>
>
> Just needed some love to work around missing 4fd786e6c3d67 ("btrfs:
> Remove 'objectid' member from struct btrfs_root"). Queued up for 4.19.
>
AFAIK I just sent out the fixed patches for 4.19 and 5.3 branches.
Thanks,
Qu
