Re: [PATCH 3.10] iwlwifi: pcie: enable oscillator for L1 exit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 04, 2014 at 05:15:16PM +0000, Grumbach, Emmanuel wrote:
> > From: Emmanuel Grumbach [mailto:egrumbach@xxxxxxxxx]
> > Sent: Tuesday, February 04, 2014 7:13 PM
> > To: Greg KH
> > Cc: stable@xxxxxxxxxxxxxxx; Grumbach, Emmanuel
> > Subject: [PATCH 3.10] iwlwifi: pcie: enable oscillator for L1 exit
> > 
> 
> I wrote here 3.10, but same resolution should work for 3.11 (you'll hit the exact same issue).

Actually, since I have backported commit 6960a05 ("iwlwifi: pcie: fix
interrupt coalescing for 7260 / 3160") into 3.11.10.2, I can do a clean
cherry-pick to 2d93aee152b1758a94a18fe15d72153ba73b5679.

Cheers,
--
Luis

> > From: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> > 
> > commit 2d93aee152b1758a94a18fe15d72153ba73b5679 upstream.
> > 
> > Enabling the oscillator consumes slightly more power (100uA) but allows to
> > make sure that we exit from L1 on time.
> > 
> > Not doing so might lead to a PCIe specification violation since we might wake
> > up from L1 at the wrong time.
> > This issue has been identified on 3160 and 7260 only.
> > On older NICs L1 off is not enabled, on newer NICs (7265), the issue is fixed.
> > 
> > When the bug occurs the user sees that the NIC has disappeared from the
> > PCI bridge, any access to the device returns 0xff.
> > 
> > This fixes:
> > 	https://bugzilla.kernel.org/show_bug.cgi?id=64541
> > 
> > and has been extensively discussed here:
> > 	http://markmail.org/thread/mfmpzqt3r333n4bo
> > 
> > Cc: stable@xxxxxxxxxxxxxxx [3.10+]
> > Fixes: 99cd47142399 ("iwlwifi: add 7000 series device configuration")
> > Reported-and-tested-by: wzyboy <wzyboy@xxxxxxxxxx>
> > Reviewed-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> > ---
> > I modified the upstream commit to compile on 3.10.
> > I simply had to remove the if.
> > The if asks if we are not dealing with a new device that doesn't need this HW
> > W/A, but this newer HW isn't supported at all in 3.10. So no condition
> > needed.
> > ---
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]