Re: Patch "ata: sata_mv: fix disk hotplug for Armada 370/XP SoCs" has been added to the 3.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 04, 2014 at 09:30:45AM +0100, Simon Guinot wrote:
> On Tue, Feb 04, 2014 at 02:34:22AM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> > 
> > This is a note to let you know that I've just added the patch titled
> > 
> >     ata: sata_mv: fix disk hotplug for Armada 370/XP SoCs
> > 
> > to the 3.4-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >      ata-sata_mv-fix-disk-hotplug-for-armada-370-xp-socs.patch
> > and it can be found in the queue-3.4 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@xxxxxxxxxxxxxxx> know about it.
> > 
> > 
> > >From 9013d64e661fc2a37a1742670202171c27fef4b5 Mon Sep 17 00:00:00 2001
> > From: Lior Amsalem <alior@xxxxxxxxxxx>
> > Date: Tue, 14 Jan 2014 20:09:57 +0100
> > Subject: ata: sata_mv: fix disk hotplug for Armada 370/XP SoCs
> > 
> > From: Lior Amsalem <alior@xxxxxxxxxxx>
> > 
> > commit 9013d64e661fc2a37a1742670202171c27fef4b5 upstream.
> > 
> > On Armada 370/XP SoCs, once a disk is removed from a SATA port, then the
> > re-plug events are not detected by the sata_mv driver. This patch fixes
> > the issue by updating the PHY speed in the LP_PHY_CTL register (0x58)
> > according to the SControl speed.
> > 
> > Note that this fix is only applied if the compatible string
> > "marvell,armada-370-sata" is found in the SATA DT node.
> > 
> > Fixes: 9ae6f740b49f ("arm: mach-mvebu: add support for Armada 370 and Armada XP with DT")
> 
> Hi Greg,
> 
> As the Armada 370 and XP SoCs are not supported by Linux 3.4, I think
> you should not apply this patch to the 3.4-stable tree.

Agreed.

> Please, let me know if there is something wrong the "Fixes:" notation
> above. I'd try to improve for the next time.

Looking at the original patch, the 'Cc: stable... v3.6+' was 9 lines
away from the Fixes line.  Perhaps we should try to keep them together?

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]