Re: [PATCH] arm64: cpufeature: Fix truncating a feature value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 10, 2019 at 01:46:21PM +0100, Suzuki K Poulose wrote:
> 
> 
> On 10/10/2019 13:29, Greg KH wrote:
> > On Thu, Oct 10, 2019 at 12:12:01PM +0100, Suzuki K Poulose wrote:
> > > All,
> > > 
> > > On 10/10/2019 12:08, Suzuki K Poulose wrote:
> > > > A signed feature value is truncated to turn to an unsigned value
> > > > causing bad state in the system wide infrastructure. This affects
> > > > the discovery of FP/ASIMD support on arm64. Fix this by making sure
> > > > we cast it properly.
> > > > 
> > > > Fixes: 4f0a606bce5ec ("arm64: cpufeature: Track unsigned fields")
> > > > Cc: stable@xxxxxxxxxxxxxxx # v4.4
> > > 
> > > Please note that this patch is only applicable for stable 4.4 tree.
> > > I should have removed the Fixes tag.
> > 
> > Why is it only for 4.4?  That needs to be documented really really
> 
> This was fixed later in v4.6 onwards with commit 28c5dcb22f90113dea
> ("arm64: Rename cpuid_feature field extract routines") rather inadvertently.
> 
> > really well in the changelog as to why this is a one-off patch, and why
> > we can't just take the relevant patches that are in Linus's tree
> > instead.
> > 
> > Please fix up and resend.
> 
> I can resend the patch with the above information included if you like.

As I said, please do, I can not take it otherwise.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux