Re: Patch "clk: jz4740: Add TCU clock" has been added to the 4.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sasha,

I think this patch shouldn't be added to the stable trees; it will cause the TCU clock to be managed by the clock framework and automatically gated after bootup since it has no client, causing a global system lockup. It's only really applicable to 5.3.

Thanks,
-Paul



Le sam., oct. 5, 2019 at 19:56, Sasha Levin <sashal@xxxxxxxxxx> a écrit :
This is a note to let you know that I've just added the patch titled

    clk: jz4740: Add TCU clock

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     clk-jz4740-add-tcu-clock.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit c72b7e327a8b4d3b870f76011f674134f9ac38f6
Author: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
Date:   Wed Jul 24 13:16:10 2019 -0400

    clk: jz4740: Add TCU clock

    [ Upstream commit 73dd11dc1a883d4c994d729dc9984f4890001157 ]

Add the missing TCU clock to the list of clocks supplied by the CGU for
    the JZ4740 SoC.

    Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
    Tested-by: Mathieu Malaterre <malat@xxxxxxxxxx>
    Tested-by: Artur Rojek <contact@xxxxxxxxxxxxxx>
    Acked-by: Stephen Boyd <sboyd@xxxxxxxxxx>
    Acked-by: Rob Herring <robh@xxxxxxxxxx>
    Signed-off-by: Paul Burton <paul.burton@xxxxxxxx>
    Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
    Cc: James Hogan <jhogan@xxxxxxxxxx>
    Cc: Jonathan Corbet <corbet@xxxxxxx>
    Cc: Lee Jones <lee.jones@xxxxxxxxxx>
    Cc: Arnd Bergmann <arnd@xxxxxxxx>
    Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
    Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
    Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>
    Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
    Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
    Cc: Rob Herring <robh+dt@xxxxxxxxxx>
    Cc: Mark Rutland <mark.rutland@xxxxxxx>
    Cc: devicetree@xxxxxxxxxxxxxxx
    Cc: linux-kernel@xxxxxxxxxxxxxxx
    Cc: linux-doc@xxxxxxxxxxxxxxx
    Cc: linux-mips@xxxxxxxxxxxxxxx
    Cc: linux-clk@xxxxxxxxxxxxxxx
    Cc: od@xxxxxxx
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/clk/ingenic/jz4740-cgu.c b/drivers/clk/ingenic/jz4740-cgu.c
index 305a26c2a800e..01b5b8b103888 100644
--- a/drivers/clk/ingenic/jz4740-cgu.c
+++ b/drivers/clk/ingenic/jz4740-cgu.c
@@ -211,6 +211,12 @@ static const struct ingenic_cgu_clk_info jz4740_cgu_clocks[] = {
 		.parents = { JZ4740_CLK_EXT, -1, -1, -1 },
 		.gate = { CGU_REG_CLKGR, 5 },
 	},
+
+	[JZ4740_CLK_TCU] = {
+		"tcu", CGU_CLK_GATE,
+		.parents = { JZ4740_CLK_EXT, -1, -1, -1 },
+		.gate = { CGU_REG_CLKGR, 1 },
+	},
 };

 static void __init jz4740_cgu_init(struct device_node *np)
diff --git a/include/dt-bindings/clock/jz4740-cgu.h b/include/dt-bindings/clock/jz4740-cgu.h
index 43153d3e9bd26..ff7c27bc98e37 100644
--- a/include/dt-bindings/clock/jz4740-cgu.h
+++ b/include/dt-bindings/clock/jz4740-cgu.h
@@ -33,5 +33,6 @@
 #define JZ4740_CLK_ADC		19
 #define JZ4740_CLK_I2C		20
 #define JZ4740_CLK_AIC		21
+#define JZ4740_CLK_TCU		22

 #endif /* __DT_BINDINGS_CLOCK_JZ4740_CGU_H__ */






[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux