On Wed, Oct 02, 2019 at 02:59:58AM +0300, Tomas Winkler wrote:
> From: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
>
> The fixed MKHI client on PCH 6 gen platforms
> does not support fw version retrieval.
> The error is not fatal, but it fills up the kernel logs and
> slows down the driver start.
> This patch disables requesting FW version on GEN6 and earlier platforms.
>
> Fixes warning:
> [ 15.964298] mei mei::55213584-9a29-4916-badf-0fb7ed682aeb:01: Could not read FW version
> [ 15.964301] mei mei::55213584-9a29-4916-badf-0fb7ed682aeb:01: version command failed -5
>
> Cc: <stable@xxxxxxxxxxxxxxx> +v4.18
> Cc: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> ---
> drivers/misc/mei/bus-fixup.c | 16 +++++++++++++---
> drivers/misc/mei/hw-me.c | 21 ++++++++++++++++++---
> drivers/misc/mei/hw-me.h | 8 ++++++--
> drivers/misc/mei/mei_dev.h | 4 ++++
> drivers/misc/mei/pci-me.c | 10 +++++-----
> 5 files changed, 46 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c
> index 32e9b1aed2ca..5ac679ac9b19 100644
> --- a/drivers/misc/mei/bus-fixup.c
> +++ b/drivers/misc/mei/bus-fixup.c
> @@ -218,13 +218,23 @@ static void mei_mkhi_fix(struct mei_cl_device *cldev)
> {
> int ret;
>
> + dev_dbg(&cldev->dev, "running hook %s\n", __func__);
That is what ftrace is for, don't sprinkle that all over the kernel for
no reason :(
thanks,
greg k-h
