Re: [PATCH v4] block: fix null pointer dereference in blk_mq_rq_timed_out()

[Yufen Yu <yuyufen@xxxxxxxxxx>]

On 2019/9/26 18:04, Jens Axboe wrote:
> On 9/25/19 2:20 PM, Yufen Yu wrote:
> > diff --git a/block/blk.h b/block/blk.h
> > index ed347f7a97b1..de258e7b9db8 100644
> > --- a/block/blk.h
> > +++ b/block/blk.h
> > @@ -30,6 +30,7 @@ struct blk_flush_queue {
> >    	 */
> >    	struct request		*orig_rq;
> >    	spinlock_t		mq_flush_lock;
> > +	blk_status_t 		rq_status;
> >    };
> Patch looks fine to me, but you should move rq_status to after the
> flush_running_idx member of struct blk_flush_queue, since then it'll
> fill a padding hole instead of adding new ones.

Thanks for you good suggestion.

Thanks,
Yufen