On Sun 22 Sep 2019 at 14:41, Sasha Levin <sashal@xxxxxxxxxx> wrote: > From: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > > [ Upstream commit 2c4956bc1e9062e5e3c5ea7612294f24e6d4fbdd ] > > So far, forwarding the hw_params of the input to output relied on the > .hw_params() callback of the cpu side of the codec2codec link to be called > first. This is a bit weak. > > Instead, override the stream params of the codec2codec to link to set it up > correctly. Hi Sasha This change depends on the following series in ASoC: https://lore.kernel.org/r/20190725165949.29699-1-jbrunet@xxxxxxxxxxxx which has also been merged in this merge window. With this change, things are done (IMO) in a better way but there was no known issue before that. I don't think it is worth backporting the mentioned ASoC series to 5.3. I would suggest to just drop this change from stable. Regards Jerome > > Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > Link: https://lore.kernel.org/r/20190729080139.32068-1-jbrunet@xxxxxxxxxxxx > Signed-off-by: Mark Brown <broonie@xxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>