Re: [PATCH 0/6] 3.13-stable timekeeping fixes merged in 3.14

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, Jan 24, 2014 at 11:27:05AM +0100, Ingo Molnar wrote:
> > 
> > * John Stultz <john.stultz@xxxxxxxxxx> wrote:
> > 
> > > On 01/23/2014 01:17 AM, Ingo Molnar wrote:
> > > > * John Stultz <john.stultz@xxxxxxxxxx> wrote:
> > > >
> > > >> Just wanted to send out a few timekeeping fixes that were merged
> > > >> in 3.14 which are appropriate for -stable.
> > > > No, they are not appropriate at all.
> > > >
> > > >> This queue backports the following fixes:
> > > >> -----------------------------------------
> > > >> f55c07607a38f84b5c7e6066ee1cfe433fa5643c	timekeeping: Fix lost updates to tai adjustment
> > > >> 5258d3f25c76f6ab86e9333abf97a55a877d3870	timekeeping: Fix potential lost pv notification of time change
> > > >> 6fdda9a9c5db367130cf32df5d6618d08b89f46a	timekeeping: Avoid possible deadlock from clock_was_set_delayed
> > > >> 04005f6011e3b504cd4d791d9769f7cb9a3b2eae	timekeeping: Fix CLOCK_TAI timer/nanosleep delays
> > > >> 330a1617b0a6268d427aa5922c94d082b1d3e96d	timekeeping: Fix missing timekeeping_update in suspend path
> > > >> d5a1c7e3fc38d9c7d629e1e47f32f863acbdec3d	rtc-cmos: Add an alarm disable quirk
> > > > These patches should have had Cc: stable in them and should have gone 
> > > > through timers/urgent!
> > > 
> > > They did have Cc: stable in them.
> > 
> > But they did not go through timers/urgent, did they?
> > 
> > > [...]
> > >
> > > I'd argue these were non-urgent fixes that should still be 
> > > backported to -stable.
> > 
> > No such thing exists really. Linus argued this repeatedly: if you 
> > think it's not urgent enough for current -git then it's doubly not 
> > urgent enough for -stable!
> 
> That's not always true, some maintainers {cough SCSI} like to see 
> patches "bake" in Linus's tree for a few days/weeks/months before 
> having the -stable tree take them.  And that's fine, I have no 
> objection to that.

That might work as long as it's not intentionally _delayed_ to skip 
Linus's tree and go into the merge window.

> Also, device ids and quirk table updates aren't usually urgent 
> enough for current, but can come into -stable just fine with a bit 
> of delay.

Sure, but this is core kernel code.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]