On Mon, Sep 16, 2019 at 06:15:59AM -0700, Guenter Roeck wrote: > On 9/15/19 11:07 PM, Greg Kroah-Hartman wrote: > > On Sun, Sep 15, 2019 at 04:01:08PM -0700, Guenter Roeck wrote: > > > Upstream commit e4849aff1e16 ("MIPS: SiByte: Enable swiotlb for SWARM, > > > LittleSur and BigSur") results in build failures in v4.4.y and v4.14.y. > > > > > > make bigsur_defconfig: > > > > > > warning: (SIBYTE_SWARM && SIBYTE_SENTOSA && SIBYTE_BIGSUR && SWIOTLB_XEN && AMD_IOMMU) selects SWIOTLB which has unmet direct dependencies (CAVIUM_OCTEON_SOC || MACH_LOONGSON64 && CPU_LOONGSON3 || NLM_XLP_BOARD || NLM_XLR_BOARD) > > > warning: (SIBYTE_SWARM && SIBYTE_SENTOSA && SIBYTE_BIGSUR && SWIOTLB_XEN && AMD_IOMMU) selects SWIOTLB which has unmet direct dependencies (CAVIUM_OCTEON_SOC || MACH_LOONGSON64 && CPU_LOONGSON3 || NLM_XLP_BOARD || NLM_XLR_BOARD) > > > > > > and the actual build: > > > > > > lib/swiotlb.o: In function `swiotlb_tbl_map_single': > > > (.text+0x1c0): undefined reference to `iommu_is_span_boundary' > > > Makefile:1021: recipe for target 'vmlinux' failed > > > > > > Please revert. > > > > Shouldn't I also revert it in 4.9.y? > > > > Yes, of course. Sorry. Somehow 4.9 keeps slipping my mind :-(. Now queued up for all of those branches, thanks. greg k-h